Class EqualsHashCodeCheck
- java.lang.Object
-
- com.puppycrawl.tools.checkstyle.api.AutomaticBean
-
- com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
-
- com.puppycrawl.tools.checkstyle.api.AbstractCheck
-
- com.puppycrawl.tools.checkstyle.checks.coding.EqualsHashCodeCheck
-
- All Implemented Interfaces:
Configurable,Contextualizable
public class EqualsHashCodeCheck extends AbstractCheck
Checks that classes that either override
equals()orhashCode()also overrides the other. This check only verifies that the method declarations matchObject.equals(Object)andObject.hashCode()exactly to be considered an override. This check does not verify invalid method names, parameters other thanObject, or anything else.Rationale: The contract of
equals()andhashCode()requires that equal objects have the same hashCode. Therefore, whenever you overrideequals()you must overridehashCode()to ensure that your class can be used in hash-based collections.To configure the check:
<module name="EqualsHashCode"/>
Example:
public static class Example1 { public int hashCode() { // code } public boolean equals(String o) { // violation, overloaded implementation of 'equals' // code } } public static class Example2 { public boolean equals(Object o) { // violation, no 'hashCode' // code } public boolean equals(String o) { // code } } public static class Example3 { public int hashCode() { // code } public boolean equals(Object o) { // OK // code } public boolean equals(String o) { // code } } public static class Example4 { public int hashCode() { // code } public boolean equals(java.lang.Object o) { // OK // code } } public static class Example5 { public static int hashCode(int i) { // code } public boolean equals(Object o) { // violation, overloaded implementation of 'hashCode' // code } } public static class Example6 { public int hashCode() { // violation, overloaded implementation of 'equals' // code } public static boolean equals(Object o, Object o2) { // code } }Parent is
com.puppycrawl.tools.checkstyle.TreeWalkerViolation Message Keys:
-
equals.noEquals -
equals.noHashCode
- Since:
- 3.0
-
-
Nested Class Summary
-
Nested classes/interfaces inherited from class com.puppycrawl.tools.checkstyle.api.AutomaticBean
AutomaticBean.OutputStreamOptions
-
-
Field Summary
Fields Modifier and Type Field Description static java.lang.StringMSG_KEY_EQUALSA key is pointing to the warning message text in "messages.properties" file.static java.lang.StringMSG_KEY_HASHCODEA key is pointing to the warning message text in "messages.properties" file.private java.util.Map<DetailAST,DetailAST>objBlockWithEqualsMaps OBJ_BLOCK to the method definition of equals().private java.util.Map<DetailAST,DetailAST>objBlockWithHashCodeMaps OBJ_BLOCKs to the method definition of hashCode().
-
Constructor Summary
Constructors Constructor Description EqualsHashCodeCheck()
-
Method Summary
All Methods Static Methods Instance Methods Concrete Methods Modifier and Type Method Description voidbeginTree(DetailAST rootAST)Called before the starting to process a tree.voidfinishTree(DetailAST rootAST)Called after finished processing a tree.int[]getAcceptableTokens()The configurable token set.int[]getDefaultTokens()Returns the default token a check is interested in.int[]getRequiredTokens()The tokens that this check must be registered for.private static booleanisEqualsMethod(DetailAST ast)Determines if an AST is a valid Equals method implementation.private static booleanisHashCodeMethod(DetailAST ast)Determines if an AST is a valid HashCode method implementation.private static booleanisObjectParam(DetailAST paramNode)Determines if an AST is a formal param of type Object.voidvisitToken(DetailAST ast)Called to process a token.-
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractCheck
clearViolations, destroy, getFileContents, getLine, getLineCodePoints, getLines, getTabWidth, getTokenNames, getViolations, init, isCommentNodesRequired, leaveToken, log, log, log, setFileContents, setTabWidth, setTokens
-
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
finishLocalSetup, getCustomMessages, getId, getMessageBundle, getSeverity, getSeverityLevel, setId, setSeverity
-
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AutomaticBean
configure, contextualize, getConfiguration, setupChild
-
-
-
-
Field Detail
-
MSG_KEY_HASHCODE
public static final java.lang.String MSG_KEY_HASHCODE
A key is pointing to the warning message text in "messages.properties" file.- See Also:
- Constant Field Values
-
MSG_KEY_EQUALS
public static final java.lang.String MSG_KEY_EQUALS
A key is pointing to the warning message text in "messages.properties" file.- See Also:
- Constant Field Values
-
objBlockWithEquals
private final java.util.Map<DetailAST,DetailAST> objBlockWithEquals
Maps OBJ_BLOCK to the method definition of equals().
-
objBlockWithHashCode
private final java.util.Map<DetailAST,DetailAST> objBlockWithHashCode
Maps OBJ_BLOCKs to the method definition of hashCode().
-
-
Constructor Detail
-
EqualsHashCodeCheck
public EqualsHashCodeCheck()
-
-
Method Detail
-
getDefaultTokens
public int[] getDefaultTokens()
Description copied from class:AbstractCheckReturns the default token a check is interested in. Only used if the configuration for a check does not define the tokens.- Specified by:
getDefaultTokensin classAbstractCheck- Returns:
- the default tokens
- See Also:
TokenTypes
-
getAcceptableTokens
public int[] getAcceptableTokens()
Description copied from class:AbstractCheckThe configurable token set. Used to protect Checks against malicious users who specify an unacceptable token set in the configuration file. The default implementation returns the check's default tokens.- Specified by:
getAcceptableTokensin classAbstractCheck- Returns:
- the token set this check is designed for.
- See Also:
TokenTypes
-
getRequiredTokens
public int[] getRequiredTokens()
Description copied from class:AbstractCheckThe tokens that this check must be registered for.- Specified by:
getRequiredTokensin classAbstractCheck- Returns:
- the token set this must be registered for.
- See Also:
TokenTypes
-
beginTree
public void beginTree(DetailAST rootAST)
Description copied from class:AbstractCheckCalled before the starting to process a tree. Ideal place to initialize information that is to be collected whilst processing a tree.- Overrides:
beginTreein classAbstractCheck- Parameters:
rootAST- the root of the tree
-
visitToken
public void visitToken(DetailAST ast)
Description copied from class:AbstractCheckCalled to process a token.- Overrides:
visitTokenin classAbstractCheck- Parameters:
ast- the token to process
-
isEqualsMethod
private static boolean isEqualsMethod(DetailAST ast)
Determines if an AST is a valid Equals method implementation.- Parameters:
ast- the AST to check- Returns:
- true if the {code ast} is a Equals method.
-
isHashCodeMethod
private static boolean isHashCodeMethod(DetailAST ast)
Determines if an AST is a valid HashCode method implementation.- Parameters:
ast- the AST to check- Returns:
- true if the {code ast} is a HashCode method.
-
isObjectParam
private static boolean isObjectParam(DetailAST paramNode)
Determines if an AST is a formal param of type Object.- Parameters:
paramNode- the AST to check- Returns:
- true if firstChild is a parameter of an Object type.
-
finishTree
public void finishTree(DetailAST rootAST)
Description copied from class:AbstractCheckCalled after finished processing a tree. Ideal place to report on information collected whilst processing a tree.- Overrides:
finishTreein classAbstractCheck- Parameters:
rootAST- the root of the tree
-
-