Class UnusedLocalVariableCheck
- java.lang.Object
-
- com.puppycrawl.tools.checkstyle.api.AutomaticBean
-
- com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
-
- com.puppycrawl.tools.checkstyle.api.AbstractCheck
-
- com.puppycrawl.tools.checkstyle.checks.coding.UnusedLocalVariableCheck
-
- All Implemented Interfaces:
Configurable,Contextualizable
public class UnusedLocalVariableCheck extends AbstractCheck
Checks that a local variable is declared and/or assigned, but not used. Doesn't support pattern variables yet. Doesn't check array components as array components are classified as different kind of variables by JLS.
To configure the check:
<module name="UnusedLocalVariable"/>
Example:
class Test { int a; { int k = 12; // violation, assigned and updated but never used k++; } Test(int a) { // ok as 'a' is a constructor parameter not a local variable this.a = 12; } void method(int b) { int a = 10; // violation int[] arr = {1, 2, 3}; // violation int[] anotherArr = {1}; // ok anotherArr[0] = 4; } String convertValue(String newValue) { String s = newValue.toLowerCase(); // violation return newValue.toLowerCase(); } void read() throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String s; // violation while ((s = reader.readLine()) != null) { } try (BufferedReader reader1 // ok as 'reader1' is a resource and resources are closed // at the end of the statement = new BufferedReader(new FileReader("abc.txt"))) { } try { } catch (Exception e) { // ok as e is an exception parameter } } void loops() { int j = 12; for (int i = 0; j < 11; i++) { // violation, unused local variable 'i'. } for (int p = 0; j < 11; p++) // ok p /= 2; } void lambdas() { Predicate<String> obj = (String str) -> { // ok as 'str' is a lambda parameter return true; }; obj.test("test"); } }Parent is
com.puppycrawl.tools.checkstyle.TreeWalkerViolation Message Keys:
-
unused.local.var
- Since:
- 9.3
-
-
Nested Class Summary
Nested Classes Modifier and Type Class Description private static classUnusedLocalVariableCheck.TypeDeclDescMaintains information about the type declaration.private static classUnusedLocalVariableCheck.VariableDescMaintains information about the variable.-
Nested classes/interfaces inherited from class com.puppycrawl.tools.checkstyle.api.AutomaticBean
AutomaticBean.OutputStreamOptions
-
-
Field Summary
Fields Modifier and Type Field Description private java.util.Map<DetailAST,UnusedLocalVariableCheck.TypeDeclDesc>anonInnerAstToTypeDeclDescMaps local anonymous inner class to the TypeDeclDesc object containing it.private java.util.Set<DetailAST>anonInnerClassHoldersSet of tokens of typeCONTAINERS_FOR_ANON_INNERSandTokenTypes.LAMBDAin some cases.private static int[]CONTAINERS_FOR_ANON_INNERSAn array of blocks in which local anon inner classes can exist.private intdepthDepth at which a type declaration is nested, 0 for top level type declarations.private static int[]INCREMENT_AND_DECREMENT_TOKENSAn array of increment and decrement tokens.static java.lang.StringMSG_UNUSED_LOCAL_VARIABLEA key is pointing to the warning message text in "messages.properties" file.private static java.lang.StringPACKAGE_SEPARATORPackage separator.private java.lang.StringpackageNameName of the package.private static int[]SCOPESAn array of scope tokens.private java.util.Deque<UnusedLocalVariableCheck.TypeDeclDesc>typeDeclarationsKeeps track of all the type declarations present in the file.private java.util.Map<DetailAST,UnusedLocalVariableCheck.TypeDeclDesc>typeDeclAstToTypeDeclDescMaps type declaration ast to their respective TypeDeclDesc objects.private static int[]UNACCEPTABLE_CHILD_OF_DOTAn array of unacceptable children of ast of typeTokenTypes.DOT.private static int[]UNACCEPTABLE_PARENT_OF_IDENTAn array of unacceptable parent of ast of typeTokenTypes.IDENT.private java.util.Deque<UnusedLocalVariableCheck.VariableDesc>variablesKeeps tracks of the variables declared in file.
-
Constructor Summary
Constructors Constructor Description UnusedLocalVariableCheck()Creates a newUnusedLocalVariableCheckinstance.
-
Method Summary
All Methods Static Methods Instance Methods Concrete Methods Modifier and Type Method Description private voidaddInstanceOrClassVar(DetailAST varDefAst)Add instance variables and class variables to theUnusedLocalVariableCheck.TypeDeclDesc.instanceAndClassVarStack.private static voidaddLocalVariables(DetailAST varDefAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Add local variables to thevariablesStackstack.voidbeginTree(DetailAST root)Called before the starting to process a tree.private static voidcheckIdentifierAst(DetailAST identAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Checks the identifier ast.private voidcustomLeaveToken(DetailAST ast, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Leave all ast nodes underanonInnerClassHoldersonce again.private voidcustomVisitToken(DetailAST ast, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Visit all ast nodes underanonInnerClassHoldersonce again.private static DetailASTfindScopeOfVariable(DetailAST variableDef)Find the scope of variable.int[]getAcceptableTokens()The configurable token set.private static DetailASTgetBlockContainingLocalAnonInnerClass(DetailAST literalNewAst)Get the block containing local anon inner class.int[]getDefaultTokens()Returns the default token a check is interested in.private java.lang.StringgetQualifiedTypeDeclarationName(DetailAST typeDeclAst)Get qualified type declaration name from type ast.int[]getRequiredTokens()The tokens that this check must be registered for.private UnusedLocalVariableCheck.TypeDeclDescgetSuperClassOfAnonInnerClass(DetailAST literalNewAst)Get theUnusedLocalVariableCheck.TypeDeclDescof the super class of anonymous inner class.private static UnusedLocalVariableCheck.TypeDeclDescgetTheNearestClass(java.lang.String outerTypeDeclName, java.util.List<UnusedLocalVariableCheck.TypeDeclDesc> typeDeclWithSameName)For all type declarations with the same name as the superclass, gets the nearest type declaration.private static intgetTypeDeclarationNameMatchingCountDiff(java.lang.String outerTypeDeclName, UnusedLocalVariableCheck.TypeDeclDesc firstTypeDecl, UnusedLocalVariableCheck.TypeDeclDesc secondTypeDecl)Get the difference between type declaration name matching count.private booleanhasSameNameAsSuperClass(java.lang.String superClassName, UnusedLocalVariableCheck.TypeDeclDesc typeDeclDesc)Whether the qualified name oftypeDeclDescmatches the super class name.private static booleanisIncrementOrDecrementVariableUsed(DetailAST exprAst)A variable with increment or decrement operator is considered used if it is used as an argument or as an array index or for assigning value to a variable.private static booleanisInsideLocalAnonInnerClass(DetailAST literalNewAst)Whether ast node of typeTokenTypes.LITERAL_NEWis a part of a local anonymous inner class.private static booleanisLeftHandSideValue(DetailAST identAst)Checks whether the ast of typeTokenTypes.IDENTis used as left-hand side value.private static booleanisNonLocalTypeDeclaration(DetailAST typeDeclAst)Whether a type declaration is non-local.private static booleanisPrivateInstanceVariable(DetailAST varDefAst)Whether instance variable or class variable have private access modifier.private static booleanisStandAloneIncrementOrDecrement(DetailAST identAst)Checks whether the ast of typeTokenTypes.IDENTis used as an operand of a stand-alone increment or decrement.private voiditerateOverBlockContainingLocalAnonInnerClass(DetailAST ast, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Iterate over all the ast nodes present underast.private voidleaveCompilationUnit()We process all the blocks containing local anonymous inner classes separately after processing all the other nodes.voidleaveToken(DetailAST ast)Called after all the child nodes have been process.private voidlogViolations(DetailAST scopeAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)TraversevariablesStackstack and log the violations.private voidmodifyVariablesStack(UnusedLocalVariableCheck.TypeDeclDesc obtainedClass, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack, DetailAST literalNewAst)Add non-private instance and class variables of the super class of the anonymous class to the variables stack.static booleanshouldCheckIdentTokenNestedUnderDot(DetailAST dotAst)Whether to check identifier token nested under dotAst.static booleanshouldCheckIdentWithMethodRefParent(DetailAST identAst)Whether an ident with parent node of typeTokenTypes.METHOD_REFshould be checked or not.private java.util.List<UnusedLocalVariableCheck.TypeDeclDesc>typeDeclWithSameName(java.lang.String superClassName)Checks if there is a type declaration with same name as the super class.private static voidvisitDotToken(DetailAST dotAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Visit ast of typeTokenTypes.DOT.private static voidvisitIdentToken(DetailAST identAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)Visit ast of typeTokenTypes.IDENT.private voidvisitLocalAnonInnerClass(DetailAST literalNewAst)Visit the local anon inner class.voidvisitToken(DetailAST ast)Called to process a token.private voidvisitTypeDeclarationToken(DetailAST typeDeclAst)Visit the type declaration token.private voidvisitVariableDefToken(DetailAST varDefAst)Visit ast of typeTokenTypes.VARIABLE_DEF.-
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractCheck
clearViolations, destroy, finishTree, getFileContents, getLine, getLineCodePoints, getLines, getTabWidth, getTokenNames, getViolations, init, isCommentNodesRequired, log, log, log, setFileContents, setTabWidth, setTokens
-
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AbstractViolationReporter
finishLocalSetup, getCustomMessages, getId, getMessageBundle, getSeverity, getSeverityLevel, setId, setSeverity
-
Methods inherited from class com.puppycrawl.tools.checkstyle.api.AutomaticBean
configure, contextualize, getConfiguration, setupChild
-
-
-
-
Field Detail
-
MSG_UNUSED_LOCAL_VARIABLE
public static final java.lang.String MSG_UNUSED_LOCAL_VARIABLE
A key is pointing to the warning message text in "messages.properties" file.- See Also:
- Constant Field Values
-
INCREMENT_AND_DECREMENT_TOKENS
private static final int[] INCREMENT_AND_DECREMENT_TOKENS
An array of increment and decrement tokens.
-
SCOPES
private static final int[] SCOPES
An array of scope tokens.
-
UNACCEPTABLE_CHILD_OF_DOT
private static final int[] UNACCEPTABLE_CHILD_OF_DOT
An array of unacceptable children of ast of typeTokenTypes.DOT.
-
UNACCEPTABLE_PARENT_OF_IDENT
private static final int[] UNACCEPTABLE_PARENT_OF_IDENT
An array of unacceptable parent of ast of typeTokenTypes.IDENT.
-
CONTAINERS_FOR_ANON_INNERS
private static final int[] CONTAINERS_FOR_ANON_INNERS
An array of blocks in which local anon inner classes can exist.
-
PACKAGE_SEPARATOR
private static final java.lang.String PACKAGE_SEPARATOR
Package separator.- See Also:
- Constant Field Values
-
variables
private final java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variables
Keeps tracks of the variables declared in file.
-
typeDeclarations
private final java.util.Deque<UnusedLocalVariableCheck.TypeDeclDesc> typeDeclarations
Keeps track of all the type declarations present in the file. Pops the type out of the stack while leaving the type in visitor pattern.
-
typeDeclAstToTypeDeclDesc
private final java.util.Map<DetailAST,UnusedLocalVariableCheck.TypeDeclDesc> typeDeclAstToTypeDeclDesc
Maps type declaration ast to their respective TypeDeclDesc objects.
-
anonInnerAstToTypeDeclDesc
private final java.util.Map<DetailAST,UnusedLocalVariableCheck.TypeDeclDesc> anonInnerAstToTypeDeclDesc
Maps local anonymous inner class to the TypeDeclDesc object containing it.
-
anonInnerClassHolders
private final java.util.Set<DetailAST> anonInnerClassHolders
Set of tokens of typeCONTAINERS_FOR_ANON_INNERSandTokenTypes.LAMBDAin some cases.
-
packageName
private java.lang.String packageName
Name of the package.
-
depth
private int depth
Depth at which a type declaration is nested, 0 for top level type declarations.
-
-
Constructor Detail
-
UnusedLocalVariableCheck
public UnusedLocalVariableCheck()
Creates a newUnusedLocalVariableCheckinstance.
-
-
Method Detail
-
getDefaultTokens
public int[] getDefaultTokens()
Description copied from class:AbstractCheckReturns the default token a check is interested in. Only used if the configuration for a check does not define the tokens.- Specified by:
getDefaultTokensin classAbstractCheck- Returns:
- the default tokens
- See Also:
TokenTypes
-
getAcceptableTokens
public int[] getAcceptableTokens()
Description copied from class:AbstractCheckThe configurable token set. Used to protect Checks against malicious users who specify an unacceptable token set in the configuration file. The default implementation returns the check's default tokens.- Specified by:
getAcceptableTokensin classAbstractCheck- Returns:
- the token set this check is designed for.
- See Also:
TokenTypes
-
getRequiredTokens
public int[] getRequiredTokens()
Description copied from class:AbstractCheckThe tokens that this check must be registered for.- Specified by:
getRequiredTokensin classAbstractCheck- Returns:
- the token set this must be registered for.
- See Also:
TokenTypes
-
beginTree
public void beginTree(DetailAST root)
Description copied from class:AbstractCheckCalled before the starting to process a tree. Ideal place to initialize information that is to be collected whilst processing a tree.- Overrides:
beginTreein classAbstractCheck- Parameters:
root- the root of the tree
-
visitToken
public void visitToken(DetailAST ast)
Description copied from class:AbstractCheckCalled to process a token.- Overrides:
visitTokenin classAbstractCheck- Parameters:
ast- the token to process
-
leaveToken
public void leaveToken(DetailAST ast)
Description copied from class:AbstractCheckCalled after all the child nodes have been process.- Overrides:
leaveTokenin classAbstractCheck- Parameters:
ast- the token leaving
-
visitDotToken
private static void visitDotToken(DetailAST dotAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Visit ast of typeTokenTypes.DOT.- Parameters:
dotAst- dotAstvariablesStack- stack of all the relevant variables in the scope
-
visitVariableDefToken
private void visitVariableDefToken(DetailAST varDefAst)
Visit ast of typeTokenTypes.VARIABLE_DEF.- Parameters:
varDefAst- varDefAst
-
visitIdentToken
private static void visitIdentToken(DetailAST identAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Visit ast of typeTokenTypes.IDENT.- Parameters:
identAst- identAstvariablesStack- stack of all the relevant variables in the scope
-
visitTypeDeclarationToken
private void visitTypeDeclarationToken(DetailAST typeDeclAst)
Visit the type declaration token.- Parameters:
typeDeclAst- type declaration ast
-
visitLocalAnonInnerClass
private void visitLocalAnonInnerClass(DetailAST literalNewAst)
Visit the local anon inner class.- Parameters:
literalNewAst- literalNewAst
-
isInsideLocalAnonInnerClass
private static boolean isInsideLocalAnonInnerClass(DetailAST literalNewAst)
Whether ast node of typeTokenTypes.LITERAL_NEWis a part of a local anonymous inner class.- Parameters:
literalNewAst- ast node of typeTokenTypes.LITERAL_NEW- Returns:
- true if variableDefAst is an instance variable in local anonymous inner class
-
logViolations
private void logViolations(DetailAST scopeAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
TraversevariablesStackstack and log the violations.- Parameters:
scopeAst- ast node of typeSCOPESvariablesStack- stack of all the relevant variables in the scope
-
leaveCompilationUnit
private void leaveCompilationUnit()
We process all the blocks containing local anonymous inner classes separately after processing all the other nodes. This is being done due to the fact the instance variables of local anon inner classes can cast a shadow on local variables.
-
isNonLocalTypeDeclaration
private static boolean isNonLocalTypeDeclaration(DetailAST typeDeclAst)
Whether a type declaration is non-local. Annotated interfaces are always non-local.- Parameters:
typeDeclAst- type declaration ast- Returns:
- true if type declaration is non-local
-
getBlockContainingLocalAnonInnerClass
private static DetailAST getBlockContainingLocalAnonInnerClass(DetailAST literalNewAst)
Get the block containing local anon inner class.- Parameters:
literalNewAst- ast node of typeTokenTypes.LITERAL_NEW- Returns:
- the block containing local anon inner class
-
addLocalVariables
private static void addLocalVariables(DetailAST varDefAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Add local variables to thevariablesStackstack. Also adds the instance variables defined in a local anonymous inner class.- Parameters:
varDefAst- ast node of typeTokenTypes.VARIABLE_DEFvariablesStack- stack of all the relevant variables in the scope
-
addInstanceOrClassVar
private void addInstanceOrClassVar(DetailAST varDefAst)
Add instance variables and class variables to theUnusedLocalVariableCheck.TypeDeclDesc.instanceAndClassVarStack.- Parameters:
varDefAst- ast node of typeTokenTypes.VARIABLE_DEF
-
isPrivateInstanceVariable
private static boolean isPrivateInstanceVariable(DetailAST varDefAst)
Whether instance variable or class variable have private access modifier.- Parameters:
varDefAst- ast node of typeTokenTypes.VARIABLE_DEF- Returns:
- true if instance variable or class variable have private access modifier
-
getSuperClassOfAnonInnerClass
private UnusedLocalVariableCheck.TypeDeclDesc getSuperClassOfAnonInnerClass(DetailAST literalNewAst)
Get theUnusedLocalVariableCheck.TypeDeclDescof the super class of anonymous inner class.- Parameters:
literalNewAst- ast node of typeTokenTypes.LITERAL_NEW- Returns:
UnusedLocalVariableCheck.TypeDeclDescof the super class of anonymous inner class
-
modifyVariablesStack
private void modifyVariablesStack(UnusedLocalVariableCheck.TypeDeclDesc obtainedClass, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack, DetailAST literalNewAst)
Add non-private instance and class variables of the super class of the anonymous class to the variables stack.- Parameters:
obtainedClass- super class of the anon inner classvariablesStack- stack of all the relevant variables in the scopeliteralNewAst- ast node of typeTokenTypes.LITERAL_NEW
-
typeDeclWithSameName
private java.util.List<UnusedLocalVariableCheck.TypeDeclDesc> typeDeclWithSameName(java.lang.String superClassName)
Checks if there is a type declaration with same name as the super class.- Parameters:
superClassName- name of the super class- Returns:
- true if there is another type declaration with same name.
-
hasSameNameAsSuperClass
private boolean hasSameNameAsSuperClass(java.lang.String superClassName, UnusedLocalVariableCheck.TypeDeclDesc typeDeclDesc)
Whether the qualified name oftypeDeclDescmatches the super class name.- Parameters:
superClassName- name of the super classtypeDeclDesc- type declaration description- Returns:
trueif the qualified name oftypeDeclDescmatches the super class name
-
getTheNearestClass
private static UnusedLocalVariableCheck.TypeDeclDesc getTheNearestClass(java.lang.String outerTypeDeclName, java.util.List<UnusedLocalVariableCheck.TypeDeclDesc> typeDeclWithSameName)
For all type declarations with the same name as the superclass, gets the nearest type declaration.- Parameters:
outerTypeDeclName- outer type declaration of anonymous inner classtypeDeclWithSameName- typeDeclarations which have the same name as the super class- Returns:
- the nearest class
-
getTypeDeclarationNameMatchingCountDiff
private static int getTypeDeclarationNameMatchingCountDiff(java.lang.String outerTypeDeclName, UnusedLocalVariableCheck.TypeDeclDesc firstTypeDecl, UnusedLocalVariableCheck.TypeDeclDesc secondTypeDecl)
Get the difference between type declaration name matching count. If the difference between them is zero, then their depth is compared to obtain the result.- Parameters:
outerTypeDeclName- outer type declaration of anonymous inner classfirstTypeDecl- first input type declarationsecondTypeDecl- second input type declaration- Returns:
- difference between type declaration name matching count
-
getQualifiedTypeDeclarationName
private java.lang.String getQualifiedTypeDeclarationName(DetailAST typeDeclAst)
Get qualified type declaration name from type ast.- Parameters:
typeDeclAst- type declaration ast- Returns:
- qualified name of type declaration
-
iterateOverBlockContainingLocalAnonInnerClass
private void iterateOverBlockContainingLocalAnonInnerClass(DetailAST ast, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Iterate over all the ast nodes present underast.- Parameters:
ast- astvariablesStack- stack of all the relevant variables in the scope
-
customVisitToken
private void customVisitToken(DetailAST ast, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Visit all ast nodes underanonInnerClassHoldersonce again.- Parameters:
ast- astvariablesStack- stack of all the relevant variables in the scope
-
customLeaveToken
private void customLeaveToken(DetailAST ast, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Leave all ast nodes underanonInnerClassHoldersonce again.- Parameters:
ast- astvariablesStack- stack of all the relevant variables in the scope
-
shouldCheckIdentWithMethodRefParent
public static boolean shouldCheckIdentWithMethodRefParent(DetailAST identAst)
Whether an ident with parent node of typeTokenTypes.METHOD_REFshould be checked or not.- Parameters:
identAst- identAst- Returns:
- true if an ident with parent node of type
TokenTypes.METHOD_REFshould be checked or if the parent type is notTokenTypes.METHOD_REF
-
shouldCheckIdentTokenNestedUnderDot
public static boolean shouldCheckIdentTokenNestedUnderDot(DetailAST dotAst)
Whether to check identifier token nested under dotAst.- Parameters:
dotAst- dotAst- Returns:
- true if ident nested under dotAst should be checked
-
checkIdentifierAst
private static void checkIdentifierAst(DetailAST identAst, java.util.Deque<UnusedLocalVariableCheck.VariableDesc> variablesStack)
Checks the identifier ast.- Parameters:
identAst- ast of typeTokenTypes.IDENTvariablesStack- stack of all the relevant variables in the scope
-
findScopeOfVariable
private static DetailAST findScopeOfVariable(DetailAST variableDef)
Find the scope of variable.- Parameters:
variableDef- ast of typeTokenTypes.VARIABLE_DEF- Returns:
- scope of variableDef
-
isLeftHandSideValue
private static boolean isLeftHandSideValue(DetailAST identAst)
Checks whether the ast of typeTokenTypes.IDENTis used as left-hand side value. An identifier is being used as a left-hand side value if it is used as the left operand of an assignment or as an operand of a stand-alone increment or decrement.- Parameters:
identAst- ast of typeTokenTypes.IDENT- Returns:
- true if identAst is used as a left-hand side value
-
isStandAloneIncrementOrDecrement
private static boolean isStandAloneIncrementOrDecrement(DetailAST identAst)
Checks whether the ast of typeTokenTypes.IDENTis used as an operand of a stand-alone increment or decrement.- Parameters:
identAst- ast of typeTokenTypes.IDENT- Returns:
- true if identAst is used as an operand of stand-alone increment or decrement
-
isIncrementOrDecrementVariableUsed
private static boolean isIncrementOrDecrementVariableUsed(DetailAST exprAst)
A variable with increment or decrement operator is considered used if it is used as an argument or as an array index or for assigning value to a variable.- Parameters:
exprAst- ast of typeTokenTypes.EXPR- Returns:
- true if variable nested in exprAst is used
-
-