public final class MutableExceptionCheck extends AbstractCheck
Ensures that exception classes (classes with names conforming to some pattern and explicitly extending classes with names conforming to other pattern) are immutable, that is, that they have only final fields.
The current algorithm is very simple: it checks that all members of exception are final.
The user can still mutate an exception's instance (e.g. Throwable has a method called
setStackTrace which changes the exception's stack trace). But, at least, all
information provided by this exception type is unchangeable.
Rationale: Exception instances should represent an error condition. Having non final fields not only allows the state to be modified by accident and therefore mask the original condition but also allows developers to accidentally forget to set the initial state. In both cases, code catching the exception could draw incorrect conclusions based on the state.
format - Specify pattern for exception class names.
Type is java.util.regex.Pattern.
Default value is "^.*Exception$|^.*Error$|^.*Throwable$".
extendedClassNameFormat - Specify pattern for extended class names.
Type is java.util.regex.Pattern.
Default value is "^.*Exception$|^.*Error$|^.*Throwable$".
To configure the check:
<module name="MutableException"/>
Parent is com.puppycrawl.tools.checkstyle.TreeWalker
Violation Message Keys:
mutable.exception
AutomaticBean.OutputStreamOptions| Modifier and Type | Field and Description |
|---|---|
private boolean |
checking
Should we check current class or not.
|
private java.util.Deque<java.lang.Boolean> |
checkingStack
Stack of checking information for classes.
|
private static java.lang.String |
DEFAULT_FORMAT
Default value for format and extendedClassNameFormat properties.
|
private java.util.regex.Pattern |
extendedClassNameFormat
Specify pattern for extended class names.
|
private java.util.regex.Pattern |
format
Specify pattern for exception class names.
|
static java.lang.String |
MSG_KEY
A key is pointing to the warning message text in "messages.properties"
file.
|
| Constructor and Description |
|---|
MutableExceptionCheck() |
| Modifier and Type | Method and Description |
|---|---|
int[] |
getAcceptableTokens()
The configurable token set.
|
int[] |
getDefaultTokens()
Returns the default token a check is interested in.
|
int[] |
getRequiredTokens()
The tokens that this check must be registered for.
|
private boolean |
isExtendedClassNamedAsException(DetailAST ast)
Checks that if extended class name conforms to specified format.
|
private boolean |
isNamedAsException(DetailAST ast)
Checks that a class name conforms to specified format.
|
private void |
leaveClassDef()
Called when we leave class definition.
|
void |
leaveToken(DetailAST ast)
Called after all the child nodes have been process.
|
void |
setExtendedClassNameFormat(java.util.regex.Pattern extendedClassNameFormat)
Setter to specify pattern for extended class names.
|
void |
setFormat(java.util.regex.Pattern pattern)
Setter to specify pattern for exception class names.
|
private void |
visitClassDef(DetailAST ast)
Called when we start processing class definition.
|
void |
visitToken(DetailAST ast)
Called to process a token.
|
private void |
visitVariableDef(DetailAST ast)
Checks variable definition.
|
beginTree, clearViolations, destroy, finishTree, getFileContents, getLine, getLineCodePoints, getLines, getTabWidth, getTokenNames, getViolations, init, isCommentNodesRequired, log, log, log, setFileContents, setTabWidth, setTokensfinishLocalSetup, getCustomMessages, getId, getMessageBundle, getSeverity, getSeverityLevel, setId, setSeverityconfigure, contextualize, getConfiguration, setupChildpublic static final java.lang.String MSG_KEY
private static final java.lang.String DEFAULT_FORMAT
private final java.util.Deque<java.lang.Boolean> checkingStack
private java.util.regex.Pattern extendedClassNameFormat
private boolean checking
private java.util.regex.Pattern format
public MutableExceptionCheck()
public void setExtendedClassNameFormat(java.util.regex.Pattern extendedClassNameFormat)
extendedClassNameFormat - a String valuepublic void setFormat(java.util.regex.Pattern pattern)
pattern - the new patternpublic int[] getDefaultTokens()
AbstractCheckgetDefaultTokens in class AbstractCheckTokenTypespublic int[] getRequiredTokens()
AbstractCheckgetRequiredTokens in class AbstractCheckTokenTypespublic int[] getAcceptableTokens()
AbstractCheckgetAcceptableTokens in class AbstractCheckTokenTypespublic void visitToken(DetailAST ast)
AbstractCheckvisitToken in class AbstractCheckast - the token to processpublic void leaveToken(DetailAST ast)
AbstractCheckleaveToken in class AbstractCheckast - the token leavingprivate void visitClassDef(DetailAST ast)
ast - class definition nodeprivate void leaveClassDef()
private void visitVariableDef(DetailAST ast)
ast - variable def node for checkprivate boolean isNamedAsException(DetailAST ast)
ast - class definition nodeprivate boolean isExtendedClassNamedAsException(DetailAST ast)
ast - class definition nodeCopyright © 2001-2022. All Rights Reserved.