org.rhq.server.metrics.invalid

Class InvalidMetricsManager

java.lang.Object

org.rhq.server.metrics.invalid.InvalidMetricsManager

public class InvalidMetricsManager
extends Object

This class tries to deal with invalid aggregate metrics. An invalid metric is one where either min > avg or max < avg. There are a couple different bugs which made these situations possible See https://bugzilla.redhat.com/show_bug.cgi?id=1110462 and https://bugzilla.redhat.com/show_bug.cgi?id=1104885 for details.

When an invalid metric is found, it is submitted to an internal queue for later processing. Metrics will be recomputed if possible; otherwise, they will be deleted.

Author:

John Sanda

Constructor Summary

Constructors

Constructor and Description
InvalidMetricsManager(DateTimeService dateTimeService, MetricsDAO dao)

Method Summary

Methods

Modifier and Type	Method and Description
DelayQueue<org.rhq.server.metrics.invalid.InvalidMetric>	getQueue() This is a test hook
boolean	isInvalidMetric(AggregateNumericMetric metric)
void	shutdown() Shuts down the executor, waiting for any in progress work to finish.
boolean	submit(AggregateNumericMetric metric) Submits an invalid metric for later processing which is done in a separate thread.

Methods inherited from class java.lang.Object

clone, equals, finalize, getClass, hashCode, notify, notifyAll, toString, wait, wait, wait

Constructor Detail

InvalidMetricsManager

public InvalidMetricsManager(DateTimeService dateTimeService,
                     MetricsDAO dao)

Method Detail

shutdown

public void shutdown()

Shuts down the executor, waiting for any in progress work to finish. Any invalid metrics that are in the queue will not be processed.

submit

public boolean submit(AggregateNumericMetric metric)

Submits an invalid metric for later processing which is done in a separate thread. The queue actually stores instances of InvalidMetric. Metrics belonging to the same measurement schedule and from the same day will only have one invalid metric stored in the queue. In other words, suppose a 1 hour metric from 14:00 is submitted. Then a 6 hour metric from 12:00 for the same schedule id is submitted. This will result in only one InvalidMetric stored stored in the queue. The reason being that we need to look at all of the 1 hour, 6 hour, and 24 hour metrics; so, multiple entries in the queue for the same day will only result in duplicate work.

Parameters:

metric - The invalid metric where invalid means either min > avg or max < avg

Returns:

true if an invalid metric is added to the queue, false otherwise

getQueue

public DelayQueue<org.rhq.server.metrics.invalid.InvalidMetric> getQueue()

This is a test hook

Returns:

The queue of invalid metrics

isInvalidMetric

public boolean isInvalidMetric(AggregateNumericMetric metric)